Deserialization #29
Merged
Deserialization #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whole deserialization works.
You can simply follow the instructions in Runner Readme and copy the whole file from Python parser without any modifications to the
runner/resources/parsein.txt.I've destructed FriConfig - inner_layers into
Array<felt252>but it is array of(felt252, VectorCommitmentConfig). To support that we need the parser to somehow encode underlying objects structure, because it needs to know how many elements are there in the array - to know that it needs to know the size of the structs inside array.I've also destructed FriWitness - layers into
Array<felt252>(that was the case where we had nested arrays) for simplicity, but we can try to deserialize it usingSerdeor enhance parser further to support objects in arrays.